fixes applied - #1078
Merged
Merged
Conversation
|
@Biokes Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1047 - Webhook creation error handling## Fix #1048 - Support transactions error handling## Fix #1049 - Update test to expect throw instead of "error" return## Fix #1050 - Add asset validation to milestone POST and PATCH
First, let me check how accepted assets are structured to understand the validation logic:Now let me update the milestone schema to include assetIssuer and add the validation:Now add validation to POST:Now add validation to PATCH:Perfect! Now let me generate the PR description:Perfect! Now let me create a summary of what was done:
Summary
I've successfully fixed all 4 issues in the new branch
fix/issues-1047-1048-1049-1050. Here's what was changed:✅ Issue #1047 - Webhook Creation Error Handling
backend/src/app.ts(line ~2824)✅ Issue #1048 - Support Transactions Error Handling
backend/src/app.ts(line ~3288)throw error;and added proper error logging with 500 response✅ Issue #1049 - Test Assertion Update
backend/src/verify-transaction.test.ts(line ~406)result === "error"toassert.rejects()expecting throw✅ Issue #1050 - Milestone Asset Validation
backend/src/app.ts(POST at ~3950, PATCH at ~4015)assetIssuerto schemacurrentAmountreset when asset changesCloses #1047
Closes #1048
Closes #1049
Closes #1050